Replace "Mac OS" and "OS X" with "macOS" #12003
Conversation
| @@ -95,6 +95,6 @@ repeat these steps to upgrade to future releases. | |||
| ## Building | |||
|
|
|||
| * [Linux](docs/build-instructions/linux.md) | |||
| * [OS X](docs/build-instructions/os-x.md) | |||
| * [macOS](docs/build-instructions/os-x.md) | |||
There was a problem hiding this comment.
We should rename the target file as well (and update the link).
| @@ -95,6 +95,6 @@ repeat these steps to upgrade to future releases. | |||
| ## Building | |||
|
|
|||
| * [Linux](docs/build-instructions/linux.md) | |||
| * [macOS](docs/build-instructions/os-x.md) | |||
| * [macOS](docs/build-instructions/mac-os.md) | |||
There was a problem hiding this comment.
Extreme nitpicking, but with the current naming scheme (look at FreeBSD), the file should be named macos.md.
PS. Not deliberately trying to 
you by the way, hehe.
|
@leo Thanks for this! 🙇 Looks good to me. @atom/feedback should we 🚢 this sooner rather than later to minimize potential merge conflicts caused by the markdown table commit bombs? |
|
👍 on merging. |
|
There are a few instances of |
| @@ -95,6 +95,6 @@ repeat these steps to upgrade to future releases. | |||
| ## Building | |||
|
|
|||
| * [Linux](docs/build-instructions/linux.md) | |||
| * [OS X](docs/build-instructions/os-x.md) | |||
| * [macOS](docs/build-instructions/macos.md) | |||
There was a problem hiding this comment.
Please don't change paths for branding purposes without having redirects, this isn't worth breaking links over
There was a problem hiding this comment.
IMHO, the day on which we'll have to change it will definitely come. And the longer we wait, the more links will break...
There was a problem hiding this comment.
@paulcbetts While I can agree in general, is it really a problem in this case? We should rename the file at some point regardless, and I say sooner rather than later.
My vote is to keep this rename. /cc @atom/feedback
As a side note, an external link directly to a file on a master branch is a bad idea exactly because of reasons such as this. Always, always link to an explicit version/commit.
There was a problem hiding this comment.
Can't you just symlink the old name to the new name to ensure links don't break?
|
@mnquintana Done! 😊 Also opened an issue on Travis CI: travis-ci/travis-ci#6200 |
|
Thanks for doing this! 🚀 🎸 |
OS X has been renamed to "macOS". More details here.