Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support "macos" value for "os" key #6200

Closed
leo opened this issue Jun 20, 2016 · 8 comments
Closed

Support "macos" value for "os" key #6200

leo opened this issue Jun 20, 2016 · 8 comments

Comments

@leo
Copy link

leo commented Jun 20, 2016

OS X has been renamed to "macOS". So this needs to be adjusted.
@leo leo changed the title Support "macos" as well as "osx" Support "macos" value for "os" key Jun 20, 2016
@leo leo mentioned this issue Jun 20, 2016
Merged
@solarce
Copy link

solarce commented Jun 20, 2016

At the moment we do not have plans to change the naming in our stuff. As Sierra approaches GA, we may add support for macos as an alias to certain things.

@solarce solarce closed this as completed Jun 20, 2016
@leo
Copy link
Author

leo commented Jun 20, 2016

Ok. But don't you simply leave the issue open then?

@JustinJiaDev
Copy link

JustinJiaDev commented Sep 11, 2016 •
edited

@solarce any plan to support macos now? Sierra will be release soon.

In addition to os, it would be great if osx_image has macos_image alias.

@leo
Copy link
Author

leo commented Sep 11, 2016

@solarce Please reopen this!

@BanzaiMan BanzaiMan mentioned this issue Sep 26, 2016
Closed
@JustinJiaDev
Copy link

I tried to open another issue (#6634) and got closed because of duplication. Maybe we should re-open this one?

@leo
Copy link
Author

leo commented Sep 26, 2016

DEFINITELY!

@solarce
Copy link

solarce commented Sep 26, 2016

I'm happy to re-open this, and while we are working on support Sierra for Xcode 8, we do not have an ETA on when we would make changes to use macos instead of osx in the places we use osx at the moment.

@solarce solarce reopened this Sep 26, 2016
@leo
Copy link
Author

leo commented Mar 3, 2018

Closing this now, as ZEIT has moved to Circle CI.

@leo leo closed this as completed Mar 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@solarce @JustinJiaDev @leo