Adds configuration option for large file warning threshold.

[remexre]

See #10086.

[50Wliu]

/cc @nathansobo is this something you're ok with being customizable?

[nathansobo]

@50Wliu Yeah I'm cool with it. Makes sense. If someone can verify this works correctly I'm 👍 to merge.

[50Wliu]

I tested this out and it works correctly. One thing though @remexre...can you please adjust this spec to respect the new config option and also to test out a different value to make sure that the option doesn't regress? Thanks!

[remexre]

Like so?

[nathansobo]

@remexre I don't think that's quite it. What we need is a test that the limit is configurable. So you would assign a limit to the configuration in the test to a number below the mocked file size and confirm we show the dialog, then reassign the limit to a number above the mocked file size and confirm we don't show the dialog.

[remexre]

Is this good?

[nathansobo]

Can you space this stuff out?

[nathansobo]

Getting close. I left a few more comments.

[remexre]

First two done, not 100% sure how to do the last one.

EDIT Actually, would it just be

if shouldPrompt
  # ...
else
  runs ->
    expect(editor).not.toBeUndefined()

?

[nathansobo]

You can also do a negative assertion on your mock...

expect(atom.applicationDelegate.confirm).not.toHaveBeenCalled()

[remexre]

I think it's fixed now? For some reason, script/test fails, claiming it doesn't have dpkg, so local tests aren't working for me...

[50Wliu]

@remexre You can view specs by clicking on the ci/circleci check. Right now there's just an issue where selectedButtonIndex is undefined. In addition, I don't think there will be an available application delegate to confirm() if the file size is beneath the limit?

[50Wliu]

This looks good now - thanks!

[nathansobo]

⚡️ Thanks @remexre!

[Ben3eeE]

Closes atom/tree-view#810?

[remexre]

I believe so.

[adamreisnz]

@remexre does this apply to actually opening files (e.g. double click), or also when previewing files from tree view (single click)? I just had the editor hang on me because I accidentally clicked on a file with 70k+ lines.

[remexre]

IIRC Previewing, I originally made it because I was annoyed by misclicking a.out instead of asourcefile.c.

[adamreisnz]

Great, thanks