Skip to content
This repository has been archived by the owner on Mar 3, 2023. It is now read-only.

Register all editors added to the workspace #12522

Merged
merged 1 commit into from
Aug 26, 2016

Conversation

maxbrunsfeld
Copy link
Contributor

@maxbrunsfeld maxbrunsfeld commented Aug 25, 2016

This replicates a bugfix that landed on master in via #12125, into the 1.10-releases branch.

Refs atom/autocomplete-plus#752

We need this before we can do another railcar release.

@maxbrunsfeld maxbrunsfeld merged commit 3266fc1 into 1.10-releases Aug 26, 2016
@maxbrunsfeld maxbrunsfeld deleted the mb-backport-editor-registry-fix branch August 26, 2016 17:31
@Ben3eeE
Copy link
Contributor

Ben3eeE commented Aug 26, 2016

Will this not be fixed in 1.9?

@maxbrunsfeld
Copy link
Contributor Author

Oh wow; I did not realize this bug existed in 1.9. Thanks for the heads up @Ben3eeE. I think we are just going to ship v1.10 (stable) on Monday, so users of 1.9.9 will get upgraded to that.

@Ben3eeE
Copy link
Contributor

Ben3eeE commented Aug 26, 2016

Alright. Just worried cause i have had this problem myself on 1.9. Excited for many things in 1.10 so happy to hear about this! There are actually few recent issues among top 4 on the autocomplete repo that might be because of this. Also last few comments in the old autocomplete wrong position issue atom/autocomplete-plus#640 seems to be this and not the position glitch. So maybe you can close some of these after 1.10 lands.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants