This repository has been archived by the owner on Mar 3, 2023. It is now read-only.
Make TokenizedBuffer and DisplayBuffer subclasses of Telepath.Model #1266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
December 7, 2013 02:25
There's a bunch of improvised code to make this work right now because of the circularity of this refactoring. It will stabilize over time.
| @@ -80,6 +80,11 @@ class Atom | |||
| setBodyPlatformClass: -> | |||
| document.body.classList.add("platform-#{process.platform}") | |||
|
|
|||
| # Public: Create a new telepath model. This won't be needed when Atom is itself | |||
There was a problem hiding this comment.
This feels like it should start out as Private: if it is going to go away soon.
There was a problem hiding this comment.
It's not going to go away. It's just that telepath.Model implements create on its own so there won't be a need to define it. I'll clarify the comment.
added 9 commits
December 7, 2013 13:59
Conflicts: package.json
|
Will start on Editor tomorrow, then on to another attempt at panes. May need to add a telepath features to allow arbitrary pane items to be inserted for backward compatibility. |
| @@ -1 +1 @@ | |||
| Subproject commit 007cf2643366f4e4aa5e38083bc69da9dc363098 | |||
| Subproject commit 5aa7984e1556e6d254f60f49a5228d8b03908ef8 | |||
There was a problem hiding this comment.
This downgraded apm on master, was this intentional?
There was a problem hiding this comment.
No this was a mistake, sorry.
|
Should #1101 be closed then now that it has been split up? |
|
Sounds good. Will keep the train rollin'. |
|
🚂💨 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doing this incrementally is going to take a few weeks off my lifespan, but here's the first step.