-
Notifications
You must be signed in to change notification settings - Fork 17.4k
Conversation
This will also affect being able to use:
|
Also, when this is disabled you will now be able to hold down a key to type is repeatably. |
# Set whether internationalization support is enabled on the editor view. | ||
# | ||
# Enabling this will display the IME popup dialog when a character is held | ||
# down and also the ability to use alt-n/alt-e to type accented characters in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and also remove the ability?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually it will allow that ability, fixed the working, thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ugh. My bad diff reading continues. I didn't read it all the way through. I'll get better at this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No worries, it was definitely missing a word or two so thanks for the feedback.
Just for some background on how other editors handle this (it looks like xcode handles it best.) alt-e enters é
alt-e can be used as a custom keybinding
|
@joshaber Do you know how Xcode could allow |
Xcode almost certainly has some custom event dispatching for its key equivalents since they're customizable. I'm not terribly sure what that means for you guys. In the context of a standard Cocoa app, this means they have a custom |
@zcbenz Do you think there's any way we could add a method to Atom shell to disable international character composition for specific |
It would get more confusing because we only want to disable international character support if there is a key binding that uses it. This means things would have to be handled on the |
I would like the keymap to have a shot at handling all keydown events. Ideally, we receive the |
I'm going to close this out, we can always revisit. |
Several keybindings are currently unusable since Mac OS X maps them to multi-keystroke accents.
Such as:
alt-n
followed by ana
types anã
alt-e
followed by ane
types ané
.This is useful if you are typing these characters but also makes the
alt-e
andalt-n
keybindings unusable in a keymap since they generate the same key eventalt-å
and you can't distinguish between two in code. Typealt-n
in the editor with the keybindings-resolver open to see for yourself.One possible fix for this is to set type
password
on the hidden input since these characters can't be typed into password fields in this manner and so the key events go back to "normal" andalt-e
andalt-n
can now be used again in keymaps.This PR adds a preference
editor.enableI18nSupport
that toggles the hidden input betweentext
andpassword
.Other ideas/approaches are welcome, this is just an initial stab at it after @benburkert reported not being able to use
alt-n
in his keymaps file.