This repository has been archived by the owner on Mar 3, 2023. It is now read-only.
Upgrade Telepath hoping to fix undefined timestamp exceptions #1292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
December 11, 2013 12:28
This will enable assertions inside of telepath to help us diagnose atom/telepath#7. Otherwise, the issue *should* be covered over for end users.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables a dev mode flag on Telepath when we aren't on releases to help us diagnose how markers are getting into a state where they don't have a timestamp to begin with. These won't run on official releases, and I added a null guard that should hopefully shield end users from this issue.