This repository has been archived by the owner on Mar 3, 2023. It is now read-only.
Add description text to the File Encoding list #13680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I updated the list of text encodings that appear in the Settings configuration menu to properly reflect the code pages supported by [encoding-selector](https://github.com/atom/encoding-selector), as well as present descriptive text in the selection menu. In the process, I removed what appeared to be a duplicate entry ('iso88597'). Note: I don't know if this change will affect the functionality of the menu, but I presume a more experience coder can figure this out.
Down10
changed the title
|
Looks good so far. Putting them into alphabetical order by description would be best. |
I kept the Chinese entries together, however.
Caught a typo.
|
I sorted the list, and I added the name "Unicode" to the related entries. |
|
Thanks for contributing! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Description of the Change
I updated the list of text encodings that appear in the Settings configuration menu to properly reflect the code pages supported by encoding-selector, as well as present descriptive text for the selection menu.
In the process, I removed what appeared to be a duplicate entry ('iso88597').
Alternate Designs
None considered. I based the syntax on the code below it (the Telemetry selection options).
Why Should This Be In Core?
It's a more user-friendly presentation of the list of supported code pages.
Benefits
Users may more easily recognize the available text encodings that Atom supports from the Settings configuration page.
Possible Drawbacks
The code may break the functionality of the menu, because I'm not aware of how the menus are constructed, to be honest. I presume a more experienced coder can figure this out.
I just thought this could be an improvement to the menu. 😃
Applicable Issues
None cited.