This repository has been archived by the owner on Mar 3, 2023. It is now read-only.
Relativize spec paths more when reporting #13825
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Description of the Change
First, here's a before/after comparison on Windows:
Much nicer.
Changes include:
.<anonymous>
syntaxfile:///
identifiers on Windows paths and converting the rest of the path to use Windows path separators (in order for it to get relativized correctly)Alternate Designs
Instead of relativizing the path twice, depending on if its in parentheses or not, a more general
line.replace(///#{_.escapeRegExp(spec.specDirectory}#{_.escapeRegExp(path.sep}///, '')
could be used. I am unsure if that would potentially relativize more than we wanted.Why Should This Be In Core?
Because it fixes already-implemented code in core.
Benefits
See before/after picture above.
Possible Drawbacks
I don't foresee any.
Applicable Issues
None.
/cc @damieng for the Windows portions.