This repository has been archived by the owner on Mar 3, 2023. It is now read-only.
Drop a basic model out from WorkspaceView #1416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 23 commits
January 14, 2014 10:58
…Instead of calling itemDestroyed on the workspace view via a DOM query
We're getting into some strange order-sensitive cases where we respond to a change of the active item before the pane has a chance to reassign the active view. Therefore it makes more sense to always just derive the active view from the active item.
"Activate" is the model level equivalent of focus.
The views are now stateless. You just construct them with a model to deserialize.
…Instead of 'workspaceView'.
nathansobo
pushed a commit
that referenced
this pull request
Jan 15, 2014
Drop a basic model out from WorkspaceView
This was referenced Dec 19, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the same thing as #1411 but I merged that one prior to the release which I didn't actually want to do.