This repository has been archived by the owner on Mar 3, 2023. It is now read-only.
Don't null out the model of a pane item view when removing it #1423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathansobo
pushed a commit
that referenced
this pull request
Jan 15, 2014
Don't null out the model of a pane item view when removing it
This was referenced Sep 15, 2021
This was referenced Sep 18, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used to assign a pane view's model to null when removing it, but I'm not sure why anymore. Something has changed in the order of operations post pane models that is leading the nulled out model to be a probable cause of #1422.