Skip to content
This repository has been archived by the owner on Mar 3, 2023. It is now read-only.

Dedupe modules #1434

Merged
merged 26 commits into from
Jan 17, 2014
Merged

Dedupe modules #1434

merged 26 commits into from
Jan 17, 2014

Conversation

kevinsawicki
Copy link
Contributor

This updates our dependencies on our own libraries to use 1.x style version strings so we can reduce duplication in the node_modules folder when installing and running apm dedupe.

This will speed up require time (and therefore startup time) since more dependencies will be shared and only need to be required once such as:

  • underscore-plus
  • fs-plus
  • theorist
  • emissary

Results

Modules installed in 0.46.0: 759 totaling 137M

Modules installed on this branch: 653 totaling 127M

@kevinsawicki
Copy link
Contributor Author

Okay, I think this is ready, major upside is script/bootstrap will now install over 100 fewer modules when ran the first time. 📉

@nathansobo
Copy link
Contributor

So awesome. And the require time improvements will be awesome.

kevinsawicki added a commit that referenced this pull request Jan 17, 2014
@kevinsawicki kevinsawicki merged commit ff88c1c into master Jan 17, 2014
This was referenced Sep 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants