This repository has been archived by the owner on Mar 3, 2023. It is now read-only.
Return true from Pane#destroyItem if item is destroyed #14884
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures that we return the correct boolean value from
Pane.prototype.destroyItem
when theforce
parameter istrue
or the item should not prompt to save.Without this, logic such as the following
... produces an uncaught error error ...
/cc @maxbrunsfeld for relevant change made in dc32018#diff-1a7d1dda35d8e7ed3ad35b9a9fd2f134L615
NOTE: Fix needs to be cherry-picked to beta on the
1.9-releases
branch in order foratom/github
CI to pass