This repository has been archived by the owner on Mar 3, 2023. It is now read-only.
Fix whacky soft-wrap issues #1492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds two important things: 1. An editor spec that randomly mutates a buffer and toggles soft wrap on and off, then compares the screen lines to a simple reference implementation to ensure everything stays in a correct state. 2. A new and radically simpler implementation of RowMap that eliminates failures in the randomized test.
|
Fixes #1454 |
|
Dev deps are fine in atom/atom |
|
I can't say I understand everything going on based on reading the diff, but it looks easier to grok than before. I say we merge it and spend some extra time in softwrap mode. |
|
|
||
| map.spliceRegions(3, 7, [{bufferRows: 5, screenRows: 5}]) | ||
|
|
||
| console.log map.inspect() |
|
Had some downtime to address the comments in the code review and merge in master. I'll leave it to you guys to merge if and when you want to. |
added 2 commits
February 2, 2014 19:52
Conflicts: src/row-map.coffee
nathansobo
pushed a commit
that referenced
this pull request
Feb 14, 2014
Fix whacky soft-wrap issues
This was referenced Sep 15, 2021
This was referenced Sep 16, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds:
RowMapthat eliminates all observed failures in the randomized test.I feel pretty good about this now. The
RowMapis way simpler now and I can't manage to get any of the failures I was previously driving out with the random spec. It's up to you guys whether you want to merge it while I'm gone. I think it might be worth it. I packaged it as a single commit so you can revert it if unexpected behaviors start cropping up.It's worth noting that I added a dev dependency for an npm I'm using in the random spec. I'm not actually sure that's a thing. @kevinsawicki perhaps you can make an adjustment if necessary?