This repository has been archived by the owner on Mar 3, 2023. It is now read-only.
Suppress default-prevented composition events on compositionstart instead of compositionupdate #15346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids creating a composition checkpoint and reverting to it on the next keystroke, which causes the cursor to move.
|
Was able to verify this fixes issue #15344! LGTM 💯 ✨ |
|
Wonderful, working for me too. Thanks for the quick fix @nathansobo ! |
as-cii
pushed a commit
that referenced
this pull request
Aug 21, 2017
Suppress default-prevented composition events on compositionstart instead of compositionupdate
as-cii
pushed a commit
that referenced
this pull request
Aug 21, 2017
Suppress default-prevented composition events on compositionstart instead of compositionupdate
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15344
In #15314, @as-cii found a workaround to composition events still firing after a default-prevented keydown event. Unfortunately, applying this workaround in the
compositionupdatehandler instead of thecompositionstarthandler meant we still created a composition checkpoint. Then, on the next input event, we detected the presence of this checkpoint and reverted to it, causing the cursor to move as in #15344.This PR moves the same logic from #15314 to
compositionstartand avoids creation of a composition checkpoint following a default-prevented keydown event./cc @as-cii @ungb @Ben3eeE