This repository has been archived by the owner on Mar 3, 2023. It is now read-only.
Don't autoscroll when using the mouse to add, delete or move selections #15546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc: @rsese |
|
Confirmed the fix on macOS 10.12.6 with this branch ✌️ |
|
I was able to verify as well before and after! LGTM! |
as-cii
pushed a commit
that referenced
this pull request
Sep 6, 2017
…-on-content Don't autoscroll when using the mouse to add, delete or move selections
as-cii
pushed a commit
that referenced
this pull request
Sep 6, 2017
…-on-content Don't autoscroll when using the mouse to add, delete or move selections
|
Hi! Where can I find thiese two files?
:) |
|
1.19.6 is perfect, thanks. :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15489
Previously, we used to scroll the editor on behalf of the user when clicking near the edges. This behavior was being perceived as jarring, because it would move up/down the line the user was trying to click:
With this pull-request we are restoring the behavior Atom 1.18 exhibited, which prevents the editor from auto-scrolling when using the mouse to add, delete or move selections:
/cc: @nathansobo @ungb @Ben3eeE @50Wliu