Skip to content
This repository has been archived by the owner on Mar 3, 2023. It is now read-only.

Update first-mate #15729

Merged
merged 5 commits into from
Oct 2, 2017
Merged

Update first-mate #15729

merged 5 commits into from
Oct 2, 2017

Conversation

@50Wliu
Copy link
Contributor Author

50Wliu commented Sep 26, 2017

Status: Blocked on seeing how many community language packages are affected by these changes.

@50Wliu
Copy link
Contributor Author

50Wliu commented Sep 27, 2017

Thanks to @Ingramz who kindly ran specs on all the language packages we identified a list of 8 grammar packages that need updating.

@Ingramz
Copy link
Contributor

Ingramz commented Sep 30, 2017

I think we can pull the trigger on this one. We could wait for feedback from the still-open pull requests, but even if there are any bugs, there should be plenty of time to react to that.

@50Wliu
Copy link
Contributor Author

50Wliu commented Oct 2, 2017

For the three remaining open PRs, all have comments that effectively say "changes looks good, and I'll probably merge after checking locally". I agree that this PR can be merged now.

@50Wliu 50Wliu merged commit 34cd21d into master Oct 2, 2017
@50Wliu 50Wliu deleted the wl-update-first-mate branch October 2, 2017 08:15
@maxbrunsfeld
Copy link
Contributor

Thanks for finishing this up @Ingramz, @50Wliu!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants