New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update first-mate #15729

Merged
merged 5 commits into from Oct 2, 2017

Conversation

Projects
None yet
3 participants
@50Wliu

This comment has been minimized.

Show comment
Hide comment
@50Wliu

50Wliu Sep 26, 2017

Member

Status: Blocked on seeing how many community language packages are affected by these changes.

Member

50Wliu commented Sep 26, 2017

Status: Blocked on seeing how many community language packages are affected by these changes.

@50Wliu

This comment has been minimized.

Show comment
Hide comment
@50Wliu

50Wliu Sep 27, 2017

Member

Thanks to @Ingramz who kindly ran specs on all the language packages we identified a list of 8 grammar packages that need updating.

Member

50Wliu commented Sep 27, 2017

Thanks to @Ingramz who kindly ran specs on all the language packages we identified a list of 8 grammar packages that need updating.

@Ingramz

This comment has been minimized.

Show comment
Hide comment
@Ingramz

Ingramz Sep 30, 2017

Contributor

I think we can pull the trigger on this one. We could wait for feedback from the still-open pull requests, but even if there are any bugs, there should be plenty of time to react to that.

Contributor

Ingramz commented Sep 30, 2017

I think we can pull the trigger on this one. We could wait for feedback from the still-open pull requests, but even if there are any bugs, there should be plenty of time to react to that.

@50Wliu

This comment has been minimized.

Show comment
Hide comment
@50Wliu

50Wliu Oct 2, 2017

Member

For the three remaining open PRs, all have comments that effectively say "changes looks good, and I'll probably merge after checking locally". I agree that this PR can be merged now.

Member

50Wliu commented Oct 2, 2017

For the three remaining open PRs, all have comments that effectively say "changes looks good, and I'll probably merge after checking locally". I agree that this PR can be merged now.

@50Wliu 50Wliu merged commit 34cd21d into master Oct 2, 2017

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@50Wliu 50Wliu deleted the wl-update-first-mate branch Oct 2, 2017

@maxbrunsfeld

This comment has been minimized.

Show comment
Hide comment
@maxbrunsfeld

maxbrunsfeld Oct 2, 2017

Contributor

Thanks for finishing this up @Ingramz, @50Wliu!

Contributor

maxbrunsfeld commented Oct 2, 2017

Thanks for finishing this up @Ingramz, @50Wliu!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment