Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Back filesystem watchers with @atom/watcher #16124
Add a new "experimental" setting for
These are known issues in @atom/watcher that I'd like to address before this merges. Mostly, these avoid regressing on some edge cases that have been reported with the current watcher.
Features and Limitations
In its current state, the experimental watcher:
It cannot currently:
Before we merge, I'd like to verify that we handle or fail gracefully in a number of trickier situations. In each scenario, if we:
These are some of the cases I've thought to try:
To Opt In
If you want to give this a try before it merges, clone and build Atom from this branch:
git clone https://github.com/atom/atom.git --branch aw-watcher cd atom script/build --install
Launch Atom and set
/cc @ungb I'd
/cc @Arcanemagus who has been helping a bunch with the @atom/watcher work.
@smashwilson I feel like for network support we should test:
in that priority order. Also, we should test them through a connection with restricted network throughput and latency generator to see what the limits are for our implementation. (In other words, will sshfs over a high-latency 3G cellular connection work as expected?)
referenced this pull request
Dec 20, 2017
On reflection I'm likely going to punt on atom/watcher#70 until after this is merged. It isn't entirely clear to me what the right thing to do is there, and I don't want to hold this up when a better solution might not involve @atom/watcher at all. What's more, nsfw also doesn't handle this well, so we're no worse off than what's currently shipped.
I would like to tackle atom/watcher#19 though.
@ungb: Do we have a samba share or an sshfs mount already available somewhere that we could use for network drive tests? It might be nice to have those available for general testing in any case