This repository has been archived by the owner on Mar 3, 2023. It is now read-only.
Enable default editor keymaps for editors located outside atom-workspace #16206
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes atom/teletype#208
This is similar to what we do for macOS keymaps:
atom/keymaps/darwin.cson
Lines 108 to 163 in 6cbc998
And would fix an issue teletype users are noticing when using editor commands in the popover. Since the popover is located outside the workspace (i.e. because it is a tooltip), keyboard shortcuts are not working for Linux and Windows users. I assume this is an issue with every package that attempts to use an editor outside the
atom-workspace
element.@atom/maintainers: what do you think?
/cc: @AlexWayfer, who originally reported the issue on atom/teletype.