New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not clobber recent project history when running specs #16255

Merged
merged 1 commit into from Nov 21, 2017

Conversation

Projects
None yet
2 participants
@50Wliu
Member

50Wliu commented Nov 21, 2017

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions

Description of the Change

Previously, whenever running specs your recent project history would get 馃敟d and completely replaced with whatever paths the tests you're running decided to open. So most of the time my recent projects history would end up with only one entry, C:\Users\user\Documents\GitHub\last-package-that-I-tested\spec\fixtures. Not very useful. This change basically nulls out the relevant history-saving methods when running specs to avoid that.

Alternate Designs

Change HistoryManager itself to prevent state storage when specs are running. This seriously impedes the ability to test it, however.

Why Should This Be In Core?

Changed the core spec helper file.

Benefits

A more useful history menu for those who run specs frequently.

Possible Drawbacks

None?

Applicable Issues

None.

@50Wliu 50Wliu merged commit 572aec7 into master Nov 21, 2017

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@50Wliu 50Wliu deleted the wl-specs-preserve-project-history branch Nov 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment