This repository has been archived by the owner on Mar 3, 2023. It is now read-only.
Do not clobber recent project history when running specs #16255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Description of the Change
Previously, whenever running specs your recent project history would get 🔥d and completely replaced with whatever paths the tests you're running decided to open. So most of the time my recent projects history would end up with only one entry,
C:\Users\user\Documents\GitHub\last-package-that-I-tested\spec\fixtures. Not very useful. This change basically nulls out the relevant history-saving methods when running specs to avoid that.Alternate Designs
Change HistoryManager itself to prevent state storage when specs are running. This seriously impedes the ability to test it, however.
Why Should This Be In Core?
Changed the core spec helper file.
Benefits
A more useful history menu for those who run specs frequently.
Possible Drawbacks
None?
Applicable Issues
None.