Fix includeNonWordCharacters regression in Cursor

[rosston]

Description of the Change

43aa3c7 (#15776) broke includeNonWordCharacters functionality of Cursor#getBeginningOfCurrentWordBufferPosition and Cursor#getEndOfCurrentWordBufferPosition. I fixed that regression.

NOTE: There are no tests here. There are no tests of Cursor that I can see. I would be happy to add some tests to cover the includeNonWordCharacters functionality, but I could use some guidance (or an example?) on how to use/clean up after using atom.workspace, etc.

Alternate Designs

Alternate designs would require needless refactoring. I just made the call to #wordRegExp look like it did before (i.e., it should be passed options).

Why Should This Be In Core?

It was broken in core.

Benefits

The regression of includeNonWordCharacters functionality will be resolved.

Possible Drawbacks

I don't see any possible drawbacks of the change.

Verification Process

I used sublime-word-navigation to verify that the bug was fixed. That package uses includeNonWordCharacters for both beginning and end of word movement. With that package installed, I:

• typed foo-bar-baz-qux into a buffer
• set the cursor at the end of the buffer: foo-bar-baz-qux|
• twice hit alt+left arrow (on macOS, adjust your word-by-word navigation shortcut by platform)

Without this fix in place, the cursor is after baz: foo-bar-baz|-qux
With this fix in place (and in Atom < 1.23.0), the cursor is in front of baz: foo-bar-|baz-qux

I did not verify that this change doesn't introduce any regressions. I am reverting a call back to what it was previously (passing in options), so I'm not very worried about regressions.

Applicable Issues

None

[50Wliu]

/cc @maxbrunsfeld

[rosston]

Sorry, I know this probably isn't very high priority, but any update on this? I'm happy to make whatever changes need to be made to get this closer to merge.

[50Wliu]

I'll try to get someone more familiar to take a look.

[maxbrunsfeld]

Thanks @rosston! Sorry for the breakage.

[rosston]

No problem! Stuff happens in software. 🙂 Thanks for taking a look!