New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'await' keyword at async function call and remove unnecessary parameter #16859

Merged
merged 1 commit into from Feb 28, 2018

Conversation

Projects
None yet
3 participants
@jerry88kim

jerry88kim commented Feb 28, 2018

Description of the Change

See DeepScan results page for more details.

Benefits

Fix bug and optimize code

Applicable Issues

#16858

@50Wliu 50Wliu requested a review from smashwilson Feb 28, 2018

@50Wliu

This comment has been minimized.

Member

50Wliu commented Feb 28, 2018

Regex change looks good, @smashwilson I think you're probably the best person to review the path-watcher changes.

@smashwilson

Oh hey, good catch 👍

@smashwilson smashwilson merged commit fc8e12f into atom:master Feb 28, 2018

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment