Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Atom.sh - identify and create atom home dir regardless of platform #17469

Merged
merged 1 commit into from Jun 5, 2018

Conversation

Projects
None yet
1 participant
@maxbrunsfeld
Copy link
Contributor

maxbrunsfeld commented Jun 5, 2018

This fixes a bug introduced in #17403. We use the ATOM_HOME variable in the definition of WAIT_FIFO, but that variable was only defined when running on Linux, not on macOS. I've updated the script to define (and ensure the existence of) ATOM_HOME on both platforms, not just Linux.

/cc @lllusion3469

@maxbrunsfeld maxbrunsfeld merged commit 41bbac7 into master Jun 5, 2018

1 of 3 checks passed

ci/circleci CircleCI is running your tests
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@maxbrunsfeld maxbrunsfeld deleted the mb-wait-fifo-fixes branch Jun 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.