This repository has been archived by the owner on Mar 3, 2023. It is now read-only.
TextEditorComponent - when updated synchronously, update even when hidden #17812
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Atom's
TextEditor
objects normally update their DOM element asynchronously for performance reasons. They also use anIntersectionObserver
to avoid unnecessary updates while they are not visible.There is currently a
setUpdatedSynchronously
method that you can use to force text editors to always update immediately. Previously, even when editors were configured to update synchronously, they would not update unless visible. This PR causes text editors which have been set to update synchronously to update their DOM immediately even when hidden. I think that this is the behavior most users would want from thesetUpdatedSynchronously
method; it's typically a method that you call on a text editor when you need to interact with its DOM element programmatically and you don't want to the normal optimizations that prevent updates.