This repository has been archived by the owner on Mar 3, 2023. It is now read-only.
Update deprecation-cop.less #18266
Merged
Update deprecation-cop.less #18266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Delete !important argument from background-color of depreciation-op
simurai
suggested changes
Oct 22, 2018
simurai
suggested changes
Oct 23, 2018
Delete !important from hover
|
@simurai changes made |
simurai
approved these changes
Nov 1, 2018
|
CI failure seems unrelated (timeout), merging. Thanks @RyanPisuena 🙇 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements for Contributing a Performance Improvement
Description of the Change
Removing '!important argument from background-color of deprecation-cop'
Quantitative Performance Benefits
According to #18174 , removing !important makes changing background color changes easier
Possible Drawbacks
May mess with current background color settings
Verification Process
Did not verify
Applicable Issues
N/A