Commits on Dec 5, 2018

1. Avoid sending async updates on config update …

   In
   atom@7a5d727
   the 'set-user-settings' callback was changed so that it nolonger
   returned the promise created by `ConfigFile.update()`. This meant that
   the logic in
   [`ApplicateDelegate.onDidChangeUserSetting()`](https://github.com/atom/atom/blob/5f0231b/src/application-delegate.js#L193-L206) which uses
   `.pendingSettingUpdateCount` to avoid triggering in response to calls to
   ApplicationDelegate.setUserSettings` was no longer effective.
   
   I noticed this when updating settings via the setting view. If you type
   at just the right (wrong?) cadence, you'll notice that your input can
   get updated with stale values.
   
   Something like this:
   
   ```
   You type            "a"      "b"            "c"
   config.set          "a"      "ab"           "ac"
   config.observe                        "a"         "ab"    "ac"
   Input value         "a"      "ab"     "a"   "ac"  "ab"    "ac"
   ```
   
   It's possible that is the same as atom/settings-view#1062
   
   After this change typing in settings input seems to behave as expected.

   

   captbaritone committed Dec 5, 2018
   Configuration menu

   • View commit details
   • Copy full SHA for 878629d
   • Browse repository at this point

   Copy the full SHA

   878629d View commit details

   Browse the repository at this point in the history