New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete 'packages/**/node_modules' in script/clean #18602

merged 1 commit into from Dec 19, 2018


None yet
1 participant
Copy link

daviwil commented Dec 19, 2018

Description of the Change

This change adds an additional step to script/lib/clean-dependencies.js which causes script/clean to delete node_modules folders for repo-local bundled packages under packages/. This is needed because repo-local package folders are symlinked into Atom's node_modules folder so deleting that folder doesn't cause those packages' node_modules folders to also be deleted.

Alternate Designs


Possible Drawbacks


Verification Process

  • Run script/clean after building Atom and verify that node_modules folders for packages in packages/ are now deleted

Release Notes


@daviwil daviwil merged commit add03bd into master Dec 19, 2018

3 checks passed

Atom Pull Requests #20181219.5 succeeded
continuous-integration/appveyor/pr AppVeyor build succeeded
continuous-integration/travis-ci/pr The Travis CI build passed

@daviwil daviwil deleted the dw-clean-packages branch Dec 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment