This repository has been archived by the owner on Mar 3, 2023. It is now read-only.
Delete 'packages/**/node_modules' in script/clean #18602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
This change adds an additional step to
script/lib/clean-dependencies.jswhich causesscript/cleanto deletenode_modulesfolders for repo-local bundled packages underpackages/. This is needed because repo-local package folders are symlinked into Atom'snode_modulesfolder so deleting that folder doesn't cause those packages'node_modulesfolders to also be deleted.Alternate Designs
None.
Possible Drawbacks
None.
Verification Process
script/cleanafter building Atom and verify thatnode_modulesfolders for packages inpackages/are now deletedRelease Notes
N/A