Skip to content
This repository has been archived by the owner on Mar 3, 2023. It is now read-only.

Fix Windows auto-update support detection #18750

Merged
merged 1 commit into from Jan 25, 2019

Conversation

smashwilson
Copy link
Contributor

Requirements for Contributing a Bug Fix

Identify the Bug

Fixes #18559.

Description of the Change

The Windows-specific AutoUpdater class had a method that was not returning the result of a delegated call, which was causing it to erroneously enter the "unsupported" state when core.automaticallyUpdate was set to "false".

Alternate Designs

N/A

Possible Drawbacks

N/A

Verification Process

Set core.automaticallyUpdate to "false". Launch Atom on Windows and open the About window. The "Check now" button and "Automatically download updates" checkbox should be visible.

Release Notes

  • Fixed a regression that caused Atom to believe it couldn't automatically update on Windows while core.automaticallyUpdate was set to "false".

@smashwilson smashwilson merged commit b08857c into master Jan 25, 2019
@smashwilson smashwilson deleted the aw/windows-supports-update branch January 25, 2019 17:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to manually update Atom with Automatically Update disabled
1 participant