This repository has been archived by the owner on Mar 3, 2023. It is now read-only.
Fix Windows auto-update support detection #18750
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements for Contributing a Bug Fix
Identify the Bug
Fixes #18559.
Description of the Change
The Windows-specific AutoUpdater class had a method that was not returning the result of a delegated call, which was causing it to erroneously enter the "unsupported" state when
core.automaticallyUpdate
was set to "false".Alternate Designs
N/A
Possible Drawbacks
N/A
Verification Process
Set
core.automaticallyUpdate
to "false". Launch Atom on Windows and open the About window. The "Check now" button and "Automatically download updates" checkbox should be visible.Release Notes
core.automaticallyUpdate
was set to "false".