Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Windows auto-update support detection #18750

Merged
merged 1 commit into from Jan 25, 2019
Merged

Conversation

@smashwilson
Copy link
Member

@smashwilson smashwilson commented Jan 25, 2019

Requirements for Contributing a Bug Fix

Identify the Bug

Fixes #18559.

Description of the Change

The Windows-specific AutoUpdater class had a method that was not returning the result of a delegated call, which was causing it to erroneously enter the "unsupported" state when core.automaticallyUpdate was set to "false".

Alternate Designs

N/A

Possible Drawbacks

N/A

Verification Process

Set core.automaticallyUpdate to "false". Launch Atom on Windows and open the About window. The "Check now" button and "Automatically download updates" checkbox should be visible.

Release Notes

  • Fixed a regression that caused Atom to believe it couldn't automatically update on Windows while core.automaticallyUpdate was set to "false".
@smashwilson smashwilson merged commit b08857c into master Jan 25, 2019
3 checks passed
3 checks passed
Atom Pull Requests #20190125.3 succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@smashwilson smashwilson deleted the aw/windows-supports-update branch Jan 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

1 participant