Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip dev mode windows when choosing an existing window for an open action #19231

Merged
merged 2 commits into from Apr 29, 2019

Conversation

Projects
None yet
1 participant
@smashwilson
Copy link
Member

commented Apr 28, 2019

Requirements for Contributing a Bug Fix

Identify the Bug

Fixes #19223, and an adjacent fault related to the same thing happening with benchmark windows.

Description of the Change

Check isSpec on candidate windows when locating an existing window to open paths in.

Alternate Designs

Rather than filtering out spec windows, I thought about flagging editor windows and adding a positive check instead. That way we'd be insulated against the addition of other new window types that shouldn't receive paths. This felt less invasive, though, and adding new window types is very rare.

Possible Drawbacks

N/A

Verification Process

  • Add a unit test and get it to pass.
  • Open an editor window and the spec runner in a dev build of Atom. Focus the spec runner, then run an atom a/1.md command on the command line. The non-spec window should be focused and the path added to it.

Release Notes

  • Test and benchmark runner windows are no longer considered for opening paths.

smashwilson added some commits Apr 28, 2019

@smashwilson smashwilson marked this pull request as ready for review Apr 28, 2019

@smashwilson smashwilson merged commit bac771e into master Apr 29, 2019

2 checks passed

Atom Pull Requests #20190428.2 succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@smashwilson smashwilson deleted the aw/no-focus-dev-mode branch Apr 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.