This repository has been archived by the owner on Mar 3, 2023. It is now read-only.
Skip dev mode windows when choosing an existing window for an open action #19231
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements for Contributing a Bug Fix
Identify the Bug
Fixes #19223, and an adjacent fault related to the same thing happening with benchmark windows.
Description of the Change
Check
isSpec
on candidate windows when locating an existing window to open paths in.Alternate Designs
Rather than filtering out spec windows, I thought about flagging editor windows and adding a positive check instead. That way we'd be insulated against the addition of other new window types that shouldn't receive paths. This felt less invasive, though, and adding new window types is very rare.
Possible Drawbacks
N/A
Verification Process
atom a/1.md
command on the command line. The non-spec window should be focused and the path added to it.Release Notes