Skip to content
This repository has been archived by the owner on Mar 3, 2023. It is now read-only.

Skip dev mode windows when choosing an existing window for an open action #19231

Merged
merged 2 commits into from Apr 29, 2019

Conversation

smashwilson
Copy link
Contributor

@smashwilson smashwilson commented Apr 28, 2019

Requirements for Contributing a Bug Fix

Identify the Bug

Fixes #19223, and an adjacent fault related to the same thing happening with benchmark windows.

Description of the Change

Check isSpec on candidate windows when locating an existing window to open paths in.

Alternate Designs

Rather than filtering out spec windows, I thought about flagging editor windows and adding a positive check instead. That way we'd be insulated against the addition of other new window types that shouldn't receive paths. This felt less invasive, though, and adding new window types is very rare.

Possible Drawbacks

N/A

Verification Process

  • Add a unit test and get it to pass.
  • Open an editor window and the spec runner in a dev build of Atom. Focus the spec runner, then run an atom a/1.md command on the command line. The non-spec window should be focused and the path added to it.

Release Notes

  • Test and benchmark runner windows are no longer considered for opening paths.

@smashwilson smashwilson marked this pull request as ready for review April 28, 2019 22:11
@smashwilson smashwilson merged commit bac771e into master Apr 29, 2019
@smashwilson smashwilson deleted the aw/no-focus-dev-mode branch April 29, 2019 00:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Open Folder" focuses spec window
1 participant