Skip to content
This repository has been archived by the owner on Mar 3, 2023. It is now read-only.

Revert inadvertent changes to package-lock.json #19404

Merged
merged 1 commit into from May 24, 2019

Conversation

nathansobo
Copy link
Contributor

🍐'd with @jasonrudolph

The changes to package-lock.json we are reverting in this PR were introduced for unknown reasons in fd82a58. Perhaps I accidentally ran npm install inside the this repository with a newer version of npm, but that's just a theory.

For whatever reason, the changes caused the following failure when building from a clean state locally on master:

./script/build --install
Node:	v8.16.0
Npm:	v6.2.0
Cleaning /Users/joe/github/atom/apm/node_modules
Cleaning /Users/joe/github/atom/node_modules
Cleaning /Users/joe/github/atom/script/node_modules
Installing script dependencies
../src/main.cc:26:15: warning: 'Call' is deprecated [-Wdeprecated-declarations]
    callback->Call(1, argv);
              ^
../../nan/nan.h:1617:3: note: 'Call' has been explicitly marked deprecated here
  NAN_DEPRECATED inline v8::Local<v8::Value>
  ^
../../nan/nan.h:98:40: note: expanded from macro 'NAN_DEPRECATED'
# define NAN_DEPRECATED __attribute__((deprecated))
                                       ^
1 warning generated.
Installing apm
../src/onig-scanner-worker.cc:37:15: warning: 'Call' is deprecated [-Wdeprecated-declarations]
    callback->Call(2, argv);
              ^
../../nan/nan.h:1739:3: note: 'Call' has been explicitly marked deprecated here
  NAN_DEPRECATED inline v8::Local<v8::Value>
  ^
../../nan/nan.h:104:40: note: expanded from macro 'NAN_DEPRECATED'
# define NAN_DEPRECATED __attribute__((deprecated))
                                       ^
../src/onig-scanner-worker.cc:43:15: warning: 'Call' is deprecated [-Wdeprecated-declarations]
    callback->Call(2, argv);
              ^
../../nan/nan.h:1739:3: note: 'Call' has been explicitly marked deprecated here
  NAN_DEPRECATED inline v8::Local<v8::Value>
  ^
../../nan/nan.h:104:40: note: expanded from macro 'NAN_DEPRECATED'
# define NAN_DEPRECATED __attribute__((deprecated))
                                       ^
2 warnings generated.
../src/onig-string.cc:30:40: warning: comparison of integers of different signs: 'int' and 'size_t' (aka 'unsigned long') [-Wsign-compare]
  hasMultiByteChars = (value->Length() != utf8_length_);
                       ~~~~~~~~~~~~~~~ ^  ~~~~~~~~~~~~
1 warning generated.
../deps/libgit2/deps/zlib/inflate.c:1507:61: warning: shifting a negative signed value is undefined [-Wshift-negative-value]
    if (strm == Z_NULL || strm->state == Z_NULL) return -1L << 16;
                                                        ~~~ ^
1 warning generated.
../src/onig-scanner-worker.cc:37:15: warning: 'Call' is deprecated [-Wdeprecated-declarations]
    callback->Call(2, argv);
              ^
../../nan/nan.h:1739:3: note: 'Call' has been explicitly marked deprecated here
  NAN_DEPRECATED inline v8::Local<v8::Value>
  ^
../../nan/nan.h:104:40: note: expanded from macro 'NAN_DEPRECATED'
# define NAN_DEPRECATED __attribute__((deprecated))
                                       ^
../src/onig-scanner-worker.cc:43:15: warning: 'Call' is deprecated [-Wdeprecated-declarations]
    callback->Call(2, argv);
              ^
../../nan/nan.h:1739:3: note: 'Call' has been explicitly marked deprecated here
  NAN_DEPRECATED inline v8::Local<v8::Value>
  ^
../../nan/nan.h:104:40: note: expanded from macro 'NAN_DEPRECATED'
# define NAN_DEPRECATED __attribute__((deprecated))
                                       ^
2 warnings generated.
../src/onig-string.cc:30:40: warning: comparison of integers of different signs: 'int' and 'size_t' (aka 'unsigned long') [-Wsign-compare]
  hasMultiByteChars = (value->Length() != utf8_length_);
                       ~~~~~~~~~~~~~~~ ^  ~~~~~~~~~~~~
1 warning generated.
../deps/libgit2/deps/zlib/inflate.c:1507:61: warning: shifting a negative signed value is undefined [-Wshift-negative-value]
    if (strm == Z_NULL || strm->state == Z_NULL) return -1L << 16;
                                                        ~~~ ^
1 warning generated.
apm  2.2.4
npm  6.2.0
node 8.9.3 x64
atom 1.39.0-dev-4057388da
python 2.7.16
git 2.21.0
Installing modules βœ—
> atom@1.39.0-dev preinstall /Users/joe/github/atom
> node -e 'process.exit(0)'


npm ERR! code ENOLOCAL
npm ERR! Could not install from "node_modules/jasmine-focused/jasmine-node@git+https:/github.com/kevinsawicki/jasmine-node.git#81af4f953a2b7dfb5bde8331c05362a4b464c5ef" as it does not contain a package.json file.

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/joe/.atom/.apm/_logs/2019-05-24T16_00_13_487Z-debug.log
child_process.js:630
    throw err;
    ^

Error: Command failed: /Users/joe/github/atom/apm/node_modules/atom-package-manager/bin/apm install
    at checkExecSyncError (child_process.js:607:13)
    at Object.execFileSync (child_process.js:627:13)
    at module.exports (/Users/joe/github/atom/script/lib/run-apm-install.js:14:16)
    at Object.<anonymous> (/Users/joe/github/atom/script/bootstrap:44:1)
    at Module._compile (module.js:653:30)
    at Object.Module._extensions..js (module.js:664:10)
    at Module.load (module.js:566:32)
    at tryModuleLoad (module.js:506:12)
    at Function.Module._load (module.js:498:3)
    at Module.require (module.js:597:17)

cc @joefitzgerald and thanks again for the heads up! ❀️

These were introduced for unknown reasons in 
fd82a58

Co-Authored-By: Jason Rudolph <jason@jasonrudolph.com>
@nathansobo nathansobo merged commit ed1734b into master May 24, 2019
@nathansobo nathansobo deleted the ns-jr/fix-package-lock branch May 24, 2019 18:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant