Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️ find-and-replace@0.219.5 #21095

Conversation

darangi
Copy link
Contributor

@darangi darangi commented Jul 21, 2020

Resolves the electron upgrade blocker

@UziTech
Copy link
Contributor

UziTech commented Jul 21, 2020

Can we get some PRs merged (or at least commented on) as well as updating these packages?

atom/find-and-replace#1112

@UziTech
Copy link
Contributor

UziTech commented Jul 21, 2020

Is anyone actually maintaining find-and-replace?

@DeeDeeG
Copy link
Contributor

DeeDeeG commented Jul 22, 2020

I tested this. I can confirm the fix worked for me.

(On a branch I made with this and #21096 merged into electron-6.1.12-bump-electron-packager-from-git, both bugs went away. 👍)

  • Find in project --> Find and Replace in project works now, tested with Electron 6.
  • Package info/settings view can be scrolled, tested with Electron 6.

My build artifacts are here: https://dev.azure.com/DeeDeeG/b/_build/results?buildId=149&view=artifacts&type=publishedArtifacts


Edit: Also works with the artifact from this specific PR: https://github.visualstudio.com/Atom/_build/results?buildId=76620&view=artifacts&type=publishedArtifacts

  • Find and Replace in project is now working for me on Electron 6.

@aminya
Copy link
Contributor

aminya commented Jul 22, 2020

Is anyone actually maintaining find-and-replace?

I have this problem with many packages in Atom. That is why I created our atom-community fork. There are no maintainers for the packages, and we do not have any access to the organization! Now Atom organization is a closed organization with minimal community involvement and very slow improvements. There are no maintainers for the packages (even though they are open source!). I am not sure how GitHub wants to advance this ecosystem with only two/three developers around. I really appreciate the efforts of the current team. But there are many volunteers that love to help, but no one knows why GitHub refuses to accept the help.

@darangi
Copy link
Contributor Author

darangi commented Jul 22, 2020

I tested this. I can confirm the fix worked for me.

(On a branch I made with this and #21096 merged into electron-6.1.12-bump-electron-packager-from-git, both bugs went away. 👍)

  • Find in project --> Find and Replace in project works now, tested with Electron 6.
  • Package info/settings view can be scrolled, tested with Electron 6.

My build artifacts are here: https://dev.azure.com/DeeDeeG/b/_build/results?buildId=149&view=artifacts&type=publishedArtifacts

Thanks for confirming this 🚀

@darangi darangi merged commit be98331 into electron-6.1.12-bump-electron-packager-from-git Jul 22, 2020
1 check passed
@sadick254 sadick254 deleted the find-and-replace-0.219.5 branch Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants