bootstrap: Update Node requirement to 10.12+ in system requirement checker

[DeeDeeG]

Requirements for Contributing a Bug Fix (from template, click to expand)

• Fill out the template below. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
• The pull request must only fix an existing bug. To contribute other changes, you must use a different template. You can see all templates at https://github.com/atom/.github/tree/master/.github/PULL_REQUEST_TEMPLATE.
• The pull request must update the test suite to demonstrate the changed functionality. For guidance, please see https://flight-manual.atom.io/hacking-atom/sections/writing-specs/.
• After you create the pull request, all status checks must be pass before a maintainer reviews your contribution. For more details, please see https://github.com/atom/.github/tree/master/CONTRIBUTING.md#pull-requests.

Identify the Bug

Companion PR to #22979.

Description of the Change

• Update the required Node to build Atom to 10.12+ in the system requirements checker script. Because...
  • Node 10.12+ has been the practical minimum requirement to build Atom as of Use the "ELECTRON_CUSTOM_VERSION" env var in build scripts #20879.
  • If bootstrap: Use legacy-compatible catch syntax (support older Node) #22979 is merged without this, users of Node < 10.12 won't be properly warned that their version of Node is too old to properly build Atom.

Alternate Designs

I suppose we could hard require Node 10.12+, but "deprecate" anything less than currently, officially upstream-supported Node versions? (12.x is the oldest Node still supported by the Node maintainers as of my writing this. See: https://nodejs.org/en/about/releases/).

(I considered not updating the required Node, but the build script errors out with older Node, so it's not a useful check if we don't update it to 10.12+. I do think Node 10.12+ is the sensible minimum requirement now.)

Possible Drawbacks

Atom might be somewhat functional without a chromedriver binary, or without a startup cache? In which case this PR makes it harder to "mostly" build Atom on certain legacy or exotic OSes that we already don't support.

Verification Process

I ran script/build --ci with Node 9, Node 10.11, and Node 10.12.

• Before this PR, Node versions 4 or newer were allowed... with only a "deprecation warning" for Node 4 or 5... and with Node 6 and above being allowed without even a warning.
• I confirmed that Node 10.11 or lower will not actually work to build Atom though, due to extract-zip@2 using the recursive option with fs.mkdir, which is only supported in Node 10.12 or newer, and can silently fail on older Node, leading to "file exists" errors in those older versions of Node.
  • Confirmed that Node 10.12 is perfectly capable of running the build scripts and producing a working build of Atom.
  • Now when attempting to bootstrap Atom on Node older than 10.12, the system requirements checker script throws a useful error message about Node being too old.

Release Notes

N/A

[darangi]

Thanks for the contribution 🙇🏾 @DeeDeeG