Bump node-fetch from 2.6.1 to 3.1.1 in /script

[dependabot]

Bumps node-fetch from 2.6.1 to 3.1.1.

Release notes

Sourced from node-fetch's releases.

v3.1.1

Security patch release

Recommended to upgrade, to not leak sensitive cookie and authentication header information to 3th party host while a redirect occurred

What's Changed

• core: update fetch-blob by @​jimmywarting in node-fetch/node-fetch#1371
• docs: Fix typo around sending a file by @​jimmywarting in node-fetch/node-fetch#1381
• core: (http.request): Cast URL to string before sending it to NodeJS core by @​jimmywarting in node-fetch/node-fetch#1378
• core: handle errors from the request body stream by @​mdmitry01 in node-fetch/node-fetch#1392
• core: Better handle wrong redirect header in a response by @​tasinet in node-fetch/node-fetch#1387
• core: Don't use buffer to make a blob by @​jimmywarting in node-fetch/node-fetch#1402
• docs: update readme for TS @​types/node-fetch by @​adamellsworth in node-fetch/node-fetch#1405
• core: Fix logical operator priority to disallow GET/HEAD with non-empty body by @​maxshirshin in node-fetch/node-fetch#1369
• core: Don't use global buffer by @​jimmywarting in node-fetch/node-fetch#1422
• ci: fix main branch by @​dnalborczyk in node-fetch/node-fetch#1429
• core: use more node: protocol imports by @​dnalborczyk in node-fetch/node-fetch#1428
• core: Warn when using data by @​jimmywarting in node-fetch/node-fetch#1421
• docs: Create SECURITY.md by @​JamieSlome in node-fetch/node-fetch#1445
• core: don't forward secure headers to 3th party by @​jimmywarting in node-fetch/node-fetch#1449

New Contributors

• @​mdmitry01 made their first contribution in node-fetch/node-fetch#1392
• @​tasinet made their first contribution in node-fetch/node-fetch#1387
• @​adamellsworth made their first contribution in node-fetch/node-fetch#1405
• @​maxshirshin made their first contribution in node-fetch/node-fetch#1369
• @​JamieSlome made their first contribution in node-fetch/node-fetch#1445

Full Changelog: node-fetch/node-fetch@v3.1.0...v3.1.1

v3.1.0

What's Changed

• fix(Body): Discourage form-data and buffer() by @​jimmywarting in node-fetch/node-fetch#1212
• fix: Pass url string to http.request by @​serverwentdown in node-fetch/node-fetch#1268
• Fix octocat image link by @​lakuapik in node-fetch/node-fetch#1281
• fix(Body.body): Normalize Body.body into a node:stream by @​jimmywarting in node-fetch/node-fetch#924
• docs(Headers): Add default Host request header to README.md file by @​robertoaceves in node-fetch/node-fetch#1316
• Update CHANGELOG.md by @​jimmywarting in node-fetch/node-fetch#1292
• Add highWaterMark to cloned properties by @​davesidious in node-fetch/node-fetch#1162
• Update README.md to fix HTTPResponseError by @​thedanfernandez in node-fetch/node-fetch#1135
• docs: switch url to URL by @​dhritzkiv in node-fetch/node-fetch#1318
• fix(types): declare buffer() deprecated by @​dnalborczyk in node-fetch/node-fetch#1345
• chore: fix lint by @​dnalborczyk in node-fetch/node-fetch#1348
• refactor: use node: prefix for imports by @​dnalborczyk in node-fetch/node-fetch#1346
• Bump data-uri-to-buffer from 3.0.1 to 4.0.0 by @​dependabot in node-fetch/node-fetch#1319
• Bump mocha from 8.4.0 to 9.1.3 by @​dependabot in node-fetch/node-fetch#1339
• Referrer and Referrer Policy by @​tekwiz in node-fetch/node-fetch#1057
• Add typing for Response.redirect(url, status) by @​c-w in node-fetch/node-fetch#1169
• chore: Correct stuff in README.md by @​Jiralite in node-fetch/node-fetch#1361
• docs: Improve clarity of "Loading and configuring" by @​serverwentdown in node-fetch/node-fetch#1323
• feat(Body): Added support for BodyMixin.formData() and constructing bodies with FormData by @​jimmywarting in node-fetch/node-fetch#1314

... (truncated)

Changelog

Sourced from node-fetch's changelog.

Changelog

All notable changes will be recorded here.

The format is based on Keep a Changelog, and this project adheres to Semantic Versioning.

What's Changed

• core: update fetch-blob by @​jimmywarting in node-fetch/node-fetch#1371
• docs: Fix typo around sending a file by @​jimmywarting in node-fetch/node-fetch#1381
• core: (http.request): Cast URL to string before sending it to NodeJS core by @​jimmywarting in node-fetch/node-fetch#1378
• core: handle errors from the request body stream by @​mdmitry01 in node-fetch/node-fetch#1392
• core: Better handle wrong redirect header in a response by @​tasinet in node-fetch/node-fetch#1387
• core: Don't use buffer to make a blob by @​jimmywarting in node-fetch/node-fetch#1402
• docs: update readme for TS @​types/node-fetch by @​adamellsworth in node-fetch/node-fetch#1405
• core: Fix logical operator priority to disallow GET/HEAD with non-empty body by @​maxshirshin in node-fetch/node-fetch#1369
• core: Don't use global buffer by @​jimmywarting in node-fetch/node-fetch#1422
• ci: fix main branch by @​dnalborczyk in node-fetch/node-fetch#1429
• core: use more node: protocol imports by @​dnalborczyk in node-fetch/node-fetch#1428
• core: Warn when using data by @​jimmywarting in node-fetch/node-fetch#1421
• docs: Create SECURITY.md by @​JamieSlome in node-fetch/node-fetch#1445
• core: don't forward secure headers to 3th party by @​jimmywarting in node-fetch/node-fetch#1449

New Contributors

• @​mdmitry01 made their first contribution in node-fetch/node-fetch#1392
• @​tasinet made their first contribution in node-fetch/node-fetch#1387
• @​adamellsworth made their first contribution in node-fetch/node-fetch#1405
• @​maxshirshin made their first contribution in node-fetch/node-fetch#1369
• @​JamieSlome made their first contribution in node-fetch/node-fetch#1445

Full Changelog: node-fetch/node-fetch@v3.1.0...v3.1.2

3.1.0

What's Changed

• fix(Body): Discourage form-data and buffer() by @​jimmywarting in node-fetch/node-fetch#1212
• fix: Pass url string to http.request by @​serverwentdown in node-fetch/node-fetch#1268
• Fix octocat image link by @​lakuapik in node-fetch/node-fetch#1281
• fix(Body.body): Normalize Body.body into a node:stream by @​jimmywarting in node-fetch/node-fetch#924
• docs(Headers): Add default Host request header to README.md file by @​robertoaceves in node-fetch/node-fetch#1316
• Update CHANGELOG.md by @​jimmywarting in node-fetch/node-fetch#1292
• Add highWaterMark to cloned properties by @​davesidious in node-fetch/node-fetch#1162
• Update README.md to fix HTTPResponseError by @​thedanfernandez in node-fetch/node-fetch#1135
• docs: switch url to URL by @​dhritzkiv in node-fetch/node-fetch#1318
• fix(types): declare buffer() deprecated by @​dnalborczyk in node-fetch/node-fetch#1345
• chore: fix lint by @​dnalborczyk in node-fetch/node-fetch#1348
• refactor: use node: prefix for imports by @​dnalborczyk in node-fetch/node-fetch#1346
• Bump data-uri-to-buffer from 3.0.1 to 4.0.0 by @​dependabot in node-fetch/node-fetch#1319
• Bump mocha from 8.4.0 to 9.1.3 by @​dependabot in node-fetch/node-fetch#1339
• Referrer and Referrer Policy by @​tekwiz in node-fetch/node-fetch#1057
• Add typing for Response.redirect(url, status) by @​c-w in node-fetch/node-fetch#1169

... (truncated)

Commits

• 36e47e8 3.1.1 release (#1451)
• 5304f3f Don't change relative location header on manual redirect (#1105)
• f5d3cf5 fix(Headers): don't forward secure headers to 3th party (#1449)
• f2c3d56 Create SECURITY.md (#1445)
• 4ae3538 core: Warn when using data (#1421)
• 41f53b9 fix: use more node: protocol imports (#1428)
• f674875 ci: fix main branch (#1429)
• 1493d04 core: Don't use global buffer (#1422)
• eb33090 Chore: Fix logical operator priority (regression) to disallow GET/HEAD with n...
• 7ba5bc9 update readme for TS @​type/node-fetch (#1405)
• Additional commits viewable in compare view

Maintainer changes

This version was pushed to npm by endless, a new releaser for node-fetch since your current version.

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

---

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

• @dependabot rebase will rebase this PR
• @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
• @dependabot merge will merge this PR after your CI passes on it
• @dependabot squash and merge will squash and merge this PR after your CI passes on it
• @dependabot cancel merge will cancel a previously requested merge and block automerging
• @dependabot reopen will reopen this PR if it is closed
• @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
• @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
• @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
• @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
• @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
• @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

[DeeDeeG]

Short summary: This PR broke a part of Nightly CI. Needs to be imported differently here, or downgraded to v2.x instead of v3.x. No known security impact to downgrading to latest v2.x, since it is just as patched for security as v3.x. is.

---

I think this broke the "Bump dependencies" job/task, which runs only on the Nightly CI pipeline.

(See: First Nightly run after this PR was merged has an error failing to import the node-fetch module: Failing CI run. All the Nightly runs since then have this same error.)

node-fetch 2.x to 3.x is a breaking change, particularly with the module switching to ESM (standard ECMAScript JS module) instead of being CommonJS (Node-style module).

It is recommended to stay on node-fetch 2.x unless we are consuming it from ESM. I don't think atom's build scripts are ESM, rather I think they are CommonJS.

See: https://github.com/node-fetch/node-fetch/blob/v3.2.0/docs/v3-UPGRADE-GUIDE.md#converted-to-es-module

This module was converted to be a ESM only package in version 3.0.0-beta.10. node-fetch is an ESM-only module - you are not able to import it with require. We recommend you stay on v2 which is built with CommonJS unless you use ESM yourself. We will continue to publish critical bug fixes for it.

Alternatively, you can use the async import() function from CommonJS to load node-fetch asynchronously:

// mod.cjs
const fetch = (...args) => import('node-fetch').then(({default: fetch}) => fetch(...args));

Note that node-fetch v2 is as patched for security as node-fetch v3, as far as I can tell from broswing the project's releases. The latest security release of v2.x and v3.x were on the same day for apparently the same vulnerability.

Edit to add: For what it's worth, I think the copy of node-fetch bumped by this PR is exclusively used here: https://github.com/atom/atom/blob/v1.59.0/script/lib/update-dependency/fetch-outdated-dependencies.js#L1

So the "correct thing to do" here consists only of correct use with regard to that one file used in the Nightly CI pipeline.

[darangi]

Thanks for catching this 🙇🏾 @DeeDeeG