This repository has been archived by the owner on Mar 3, 2023. It is now read-only.
Add ability to scroll past the end of the file #3619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looking at this... |
|
Code seems fine. Can you write a spec for it? Maybe in the section here: https://github.com/atom/atom/blob/master/spec/display-buffer-spec.coffee#L1093 in a
|
|
Sure thing. I'll take care of it when I get home from work tonight. |
|
👍 |
|
Added the specs and rebased on the latest master. |
|
Awesome ✨ |
benogle
added a commit
that referenced
this pull request
Sep 26, 2014
Add ability to scroll past the end of the file
|
Great. I just unpublished my package. |
|
Cool |
|
Just active it from: Edit / preferences |
This was referenced May 4, 2021
This was referenced May 13, 2021
This was referenced May 21, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3592
Since @thedaniel suggested that this should be part of the default behavior, I took some of the code from the scroll-past-end package and added the functionality.