This repository has been archived by the owner on Mar 3, 2023. It is now read-only.
Load TextMate grammars with async I/O instead of a worker thread #448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old name was misleading because it the decision is based on the file contents in some circumstances.
It's also an extremely simple grammar, so we'll do less work to initially tokenize open buffers before loading their real grammars.
Just don't create entry objects for them.
This is a temporary solution so we can merge async textmate package loading. I'd like to dispense with this event and consider each grammar individually as they are loaded. But this makes the behavior compatible with the old background-task-based behavior.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This isn't quite how I'd like it because it still emits a global 'grammars-loaded' event after all the packages have been loaded. It uses a queue to serialize the loading of each package's grammars, then emits this event when the queue is empty. Instead, I'd like to fire an event every time a grammar is added and have a
LanguageModeswitch to that grammar if it is a better match. Then any time a grammar is added we can respond appropriately with the currently open edit sessions. But I want to clean up package loading first so this was a good way to get this merged to master now.