This repository has been archived by the owner on Mar 3, 2023. It is now read-only.
Throw an exception when adding a non-object pane item #7633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -336,6 +336,8 @@ class Pane extends Model | |||
| # | |||
| # Returns the added item. | |||
| addItem: (item, index=@getActiveItemIndex() + 1) -> | |||
| throw new Error("Added a null item") unless item? and typeof item is 'object' | |||
There was a problem hiding this comment.
The error message seems a bit confusing since it isn't always a null item, it also throws for numbers and strings right?
There was a problem hiding this comment.
You're right. Oversight. I expanded to non-objects and forgot to update the message.
nathansobo
force-pushed
the
ns-pane-items-must-be-objects
branch
from
dc04e79
to
8348b2c
Compare
nathansobo
pushed a commit
that referenced
this pull request
Jul 1, 2015
Throw an exception when adding a non-object pane item
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5978
We end up attempting to retrieve a view for pane items from a WeakMap, which can only use objects as keys. Throwing an exception earlier helps to clarify to package authors that this won't work.