Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Snippets still aren't html escaped #536

Closed
nosami opened this issue Jul 18, 2015 · 3 comments
Closed

Snippets still aren't html escaped #536

nosami opened this issue Jul 18, 2015 · 3 comments
Labels
more-information-needed

Comments

@nosami
Copy link

nosami commented Jul 18, 2015

Sorry to have to tell you this, but it seems that this bug is still there in v1.0.2

Look at the 2nd item here AddRange(IEnumerable collection)

parameters not escaped

It should be AddRange(IEnumerable<string> collection
completion result

Although it looks as though other parts of the completion are escaped now... I can see < and > elsewhere, just not inside the paramater snippets.

completions are escaped
@50Wliu 50Wliu added the bug label Jul 18, 2015
@benogle benogle mentioned this issue Jul 20, 2015
Closed
@benogle
Copy link
Contributor

benogle commented Jul 21, 2015

What version of atom are you on? Can you paste in an example suggestion hash? What package is generating this list?

They are being escaped for me:

screen shot 2015-07-21 at 3 16 11 pm

@benogle
Copy link
Contributor

benogle commented Jul 21, 2015

I wonder if it has to do with escaping here. An example suggestion hash would be amazing.

Edit: or maybe you're rendering the snippets yourself? I'm not seeing the code to set DisplayText in omnisharp. Looking...

@benogle
Copy link
Contributor

benogle commented Jul 22, 2015

Closing this as fixed. I am unable to reproduce. @nosami if there is still an issue, please reopen with an example hash of what you are passing back to ac+.

@benogle benogle closed this as completed Jul 22, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
more-information-needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@benogle @nosami @50Wliu