This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Do not show background tips unless focused #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
50Wliu
force-pushed
the
wl-battery-life
branch
from
d9e6276
to
d7a1b76
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Description of the Change
Only show background tips when Atom is focused to preserve battery life.
In the following GIFs, the slightly highlighted line in the Task Manager represents Atom. Notice the GPU usage when Atom is and isn't focused. (Note that I decreased the display duration to 1 second for a shorter GIF)
Alternate Designs
None.
Benefits
Uses public Atom and Electron APIs to detect when Atom isn't focused and deactivates the background tips and timers in order to save battery life. I have verified that the new listeners are disposed of correctly when the package is deactivated.
Possible Drawbacks
When Atom is still visible but not focused, no background tips will appear.
Applicable Issues
None.