This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Add ability to pull selected text into replace field #1064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ield, as requested in #67
…nd-pattern is called
daviwil
approved these changes
Jan 8, 2019
lib/find-view.js
Outdated
| if (findPattern) { | ||
| this.findEditor.setText(findPattern); | ||
| this.search(); |
There was a problem hiding this comment.
Looks like this no longer activates the search immediately, is that the desired behavior?
There was a problem hiding this comment.
Ah you're right, I thought this wasn't doing anything useful, but it turns out it does have a purpose if live search is disabled. I'll push a new commit fixing that.
|
Thanks @50Wliu! Looks good, merging it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Description of the Change
This is an update of #719.
Alternate Designs
None.
Benefits
Allows the replace field to be easily populated with the selected text.
Possible Drawbacks
People may already be using ctrl-shift-e for other purposes.
Applicable Issues
#67.
Supersedes and closes #719.