Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to pull selected text into replace field #1064

Merged
merged 10 commits into from Jan 10, 2019

Conversation

Projects
None yet
3 participants
@50Wliu
Copy link
Member

50Wliu commented Dec 28, 2018

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions

Description of the Change

This is an update of #719.

Alternate Designs

None.

Benefits

Allows the replace field to be easily populated with the selected text.

Possible Drawbacks

People may already be using ctrl-shift-e for other purposes.

Applicable Issues

#67.
Supersedes and closes #719.

ruthgrace and others added some commits May 11, 2016

@daviwil

daviwil approved these changes Jan 8, 2019

Copy link
Member

daviwil left a comment

All looks good except for one question!

if (findPattern) {
this.findEditor.setText(findPattern);
this.search();

This comment has been minimized.

@daviwil

daviwil Jan 8, 2019

Member

Looks like this no longer activates the search immediately, is that the desired behavior?

This comment has been minimized.

@50Wliu

50Wliu Jan 9, 2019

Author Member

Ah you're right, I thought this wasn't doing anything useful, but it turns out it does have a purpose if live search is disabled. I'll push a new commit fixing that.

50Wliu added some commits Jan 9, 2019

@daviwil

This comment has been minimized.

Copy link
Member

daviwil commented Jan 10, 2019

Thanks @50Wliu! Looks good, merging it.

@daviwil daviwil merged commit a4cdbb6 into master Jan 10, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@daviwil daviwil deleted the wl-ruthgrace-slurp-replace branch Jan 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.