This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Results pane direction option (#585, #597) #829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The specs were failing because the confirm method overwrote its options parameter when the pane setting was set, and that parameter contains the pending flag. Now we just add the split attribute to the existing options object.
|
Thanks @HebaruSan and @bencolon! This looks great. It will go out in Atom 1.14. |
maxbrunsfeld
added a commit
that referenced
this pull request
Jan 5, 2017
|
FYI, I have tweaked the name of the setting. It is now |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would be great to be able to open project-find results in a downward pane as per #585, so I'm attempting to update and address the comments on #597 by @bencolon. Changes from that PR: