This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Don't use deprecated [l]statSyncNoException methods in Electron >= 3 #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonrudolph
approved these changes
Dec 14, 2018
|
Yep, just open an Atom build with Electron 3.0: Before
After
Opening any folder in tree-view will cause a bunch of deprecation warning spew without these changes. The last two warnings are coming from a package or library that uses the |
maxbrunsfeld
approved these changes
Dec 14, 2018
|
Added some verification steps with a couple other cases to try! Will run through those before merging/shipping. |
5 tasks
rafeca
added a commit
to rafeca/coffeestack
that referenced
this pull request
May 15, 2019
This PR upgrades the `fs-plus` dependency to get rid of the deprecation warnings that appear on the console when running this module on Node v10. More info: atom/fs-plus#46
This was referenced May 15, 2019
as-cii
pushed a commit
to atom/atom
that referenced
this pull request
May 20, 2019
This commit fixes some deprecation warnings we were observing in our test suite, as well as when opening packages that registered protocol handlers such as the `welcome` package. The warnings were due to using the `fs.(l)statSyncNoException` API, which will be deprecated from Electron 4 onwards. We had already dealt with this by shipping atom/fs-plus#46, which provided a shim on `fs-plus` to suppress the warning. However, `AtomProtocolHandler` was still using the standard `fs` module, which was causing the warning to be displayed whenever a package registered a URL opener.
This was referenced Jun 3, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fs.statSyncNoExceptionandfs.lstatSyncNoExceptionhave been deprecated in Electron 3.0 and might be removed in a future release. This change updatesfs-plusto expose wrappers that only use these methods when thefsmodule provides them and we're not currently running in Electron 3.0 or higher.Verification Steps
fsmethod are not used in Electron 3.0 appsfsmethods are used in Electron 2.0 and lower appsfs-plusimplementation is used in plain Node.js apps