Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Option to ignore VCS excluded paths? #148

Closed
jesseleite opened this issue Oct 29, 2015 · 17 comments
Closed

Option to ignore VCS excluded paths? #148

jesseleite opened this issue Oct 29, 2015 · 17 comments

Comments

@jesseleite
Copy link

I know this sounds a bit crazy, but I have the Exclude VCS Ignored Paths option checked so that I can do a project-wide find and replace without touching vendor dependencies.

screen shot 2015-10-29 at 5 24 29 pm

For example, I'm a heavy Laravel user, which uses PHP composer to pull dependencies into my project's /vendor folder. The exclude VCS option is great for limiting find/replace scope, but I often find myself trying to look up vendor source code using the fuzzy finder, for documentation purposes. It's often faster for me to fuzzy finder into a vendor class to learn about available methods, than it is for me to open browser and hunt through web-based docs.

screen shot 2015-10-29 at 5 23 20 pm

All that said, it'd be nice if we could somehow configure fuzzy-finder to ignore that Exclude VCS Ignored Paths option. Thoughts?

@thedaniel
Copy link
Contributor

There's probably some way to provide this functionality within the editor, I know I find myself dropping into the terminal and using grep for it from time to time - I'm not sure if that is a setting, or a separate fuzzy-finder command for searching the full project without ignores. In any case, I'll add some labels and cc @atom/feedback for now.

@asiniy

This comment has been minimized.

@jesseleite
Copy link
Author

Thanks @thedaniel. I like the idea of separate fuzzy-finder command for searching full project without ignores. Not sure how to implement though, because Amateur.

@kaicataldo
Copy link

I'd love to see this functionality, either by:

  • being able to bind a second keymapping that will search the entire contents of the directory whether the "Exclude VCS Ignored Paths" is set or not
  • starting the search query off with a character that denotes that this should search the entire directory

My preference is for the former. I'd be happy to try to implement this if it's something that would be accepted 😄

@tiagocpontesp

This comment has been minimized.

@davesnx
Copy link

davesnx commented May 26, 2016

Thanks @50Wliu, and sorry :(

@jacquescrocker

This comment has been minimized.

@tienduccao

This comment has been minimized.

@caillou
Copy link

caillou commented Dec 13, 2016

I regularly miss having a shortcut to tell fuzzy-finder to search in the ignored files. The most common reason is that I would like to look at the implementation of a file in the node_modules folder.

Ideally this would be implemented as a keybinding or leading character (like : for jump to line).

Is there a major difficulty in implementing such an option?

@nathansobo
Copy link
Contributor

No major difficulty other than ironing out the UX and taking time away from other things. Want to give it a shot?

@caillou
Copy link

caillou commented Dec 14, 2016

@nathansobo Not having worked on any atom related code before, I might first choose to work on Beginner issues.

Or would you consider this one a fairly simple task? If so, could you give me a hint or two as to how you would get started on this? I have worked with CoffeeScript for over a year, so this should not be a problem.

@bboure
Copy link

bboure commented Jan 31, 2017

I vote for this one too. I often find myself want to lookup vendors for the same reasons as explained above. Would be great to be able to exceptionally bypass the ignored paths with a specific command.

Might also be useful to "remove" a file/directory from the ignored paths (i.e.: add it back to the index)
e.g.: You have a non-versioned secret file or custom config file and still want to search for it.

@stevgouws

This comment has been minimized.

2 similar comments
@smonetti

This comment has been minimized.

@jacktuck

This comment has been minimized.

@lee-dohm
Copy link
Contributor

Thanks everyone for the feedback on this idea 👍

This is something that we agree that would be beneficial. It isn't something that the Atom maintainers team is going to be addressing ourselves in the near future though. Because we treat our issues list as the Atom team's backlog, we close issues that we aren't going to be working on ourselves to be more transparent about what it is we are planning on working on and what we aren't.

We would be interested in evaluating a well-written pull request for this though, so I'll leave the help-wanted label on this so others can find it more easily.

Thanks again for your interest in Atom!

@AlexWayfer
Copy link

Because we treat our issues list as the Atom team's backlog, we close issues that we aren't going to be working on ourselves to be more transparent about what it is we are planning on working on and what we aren't.

We would be interested in evaluating a well-written pull request for this though, so I'll leave the help-wanted label on this so others can find it more easily.

You can leave help-wanted issues open (because they're not resolved) and exclude help-wanted issues from your team's backlog.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests