"github" package causes Atom to not save or open files

[larsgw]

Prerequisites

• Put an X between the brackets on this line if you have done all of the following:
  • Reproduced the problem in Safe Mode: https://flight-manual.atom.io/hacking-atom/sections/debugging/#using-safe-mode
  • Followed all applicable steps in the debugging guide: https://flight-manual.atom.io/hacking-atom/sections/debugging/
  • Checked the FAQs on the message board for common solutions: https://discuss.atom.io/c/faq
  • Checked that your issue isn't already filed: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aatom
  • Checked that there is not already an Atom package that provides the described functionality: https://atom.io/packages

Note: --clear-window-state does not seem to do much, but from what I have seen it does not help with the issue.

Description

After opening a few files, I cannot save changes or open additional files. This is fixed for a while after restarting, but not for long. I narrowed it down to the github package (with an open Git tab).

Steps to Reproduce

1. Open the Git tab
2. Open files
3. Save changes to files

Expected behavior:

Continue to be able to open and save files.

Actual behavior:

Saving and opening silently fails, both in terms of UI and what is in the file system.

Reproduces how often:

Every time, but the number of files you can open seems to differ. I only ever get to save once though.

Versions

> atom -v
Atom    : 1.41.0
Electron: 4.2.7
Chrome  : 69.0.3497.128
Node    : 10.11.0

> uname -v
atom/atom#1 SMP Debian 5.3.7-1 (2019-10-19)

Additional Information

• See also Atom is not saving atom#18114 (locked due to inactivity and a lot of "+1"s from people with other problems)
• I posted on the forum

[flamein]

Could this be related to #2308?

[larsgw]

Not sure but it also seems related to an issue posted in 2018, a year before that PR. I did some more testing and I could not reproduce the problem in a newly initialized repository without an origin. However, after adding an origin (only git remote add origin https://..., no fetching) the problem did start occurring again.

[flamein]

This behaviour definitely wasn't around until very recently. I am a heavy user of github integration, and it showed up around the same time I noticed they changed the way they handle git context.

[flamein]

By the way, If you, like me cannot work properly until GitHub decides to do something about this situation, you can revert to older github package version like this:

$ apm install github@0.31.0-1
The github package is bundled with Atom and should not be explicitly installed.
You can run `apm uninstall github` to uninstall it and then the version bundled
with Atom will be used.
Installing github@0.31.0-1 to /home/f_lamein/.atom/packages ✓           

They introduced the new behaviour in version 0.31.1-x

It will immediately tell you there is a newer version available, so don't upgrade it until you know they fixed it. When they do, you should remove github package like mentioned above to switch back to bundled version

[larsgw]

I am still on 0.30.1; I stopped using the package due to this problem before ever seeing the project dropdown thing.

[smashwilson]

By the way, If you, like me cannot work properly until GitHub decides to do something about this situation [..]

Are you already following #2335? We're discussing git context management changes there. I'd be curious to know if the directions we're considering would be sufficient for you.

As for the actual issue here: this is an utter mystery to me and I'm not sure where to even start debugging it. I don't believe this package hooks save or open actions at all. Maybe we're exhausting open file descriptors or something?

Are there any errors in the console when you try to save or open? Or, if not there, on the terminal if you launch atom with the --foreground --enable-electron-debugging flags?

[larsgw]

I don't believe this package hooks save or open actions at all.

I was looking for something like that too, but I had no idea where to look for that.

Maybe we're exhausting open file descriptors or something?

Given the intermittentness, if there are no hooks then that makes sense to me. Does having a remote impact file descriptors?

Are there any errors in the console when you try to save or open? Or, if not there, on the terminal if you launch atom with the --foreground --enable-electron-debugging flags?

Only violations in the console and generic Gtk warnings on the terminal. I did get some errors regarding the nsfw package in 1.40.1 but it looks like that was not related (either way, it did not seem to correspond to the bug occurring anyway).

Console warnings

[Violation] 'load' handler took 166ms
[Violation] Added non-passive event listener to a scroll-blocking  event. Consider marking event handler as 'passive' to make the page more responsive. See 
[Violation] Forced reflow while executing JavaScript took 106ms
[Violation] Forced reflow while executing JavaScript took 53ms

Gtk warnings

(atom:24460): Gtk-WARNING **: 17:14:02.694: Theme parsing error: gtk.css:127:35: The style property GtkButton:child-displacement-x is deprecated and shouldn't be used anymore. It will be removed in a future version
(atom:24460): Gtk-WARNING **: 17:14:02.694: Theme parsing error: gtk.css:128:35: The style property GtkButton:child-displacement-y is deprecated and shouldn't be used anymore. It will be removed in a future version
(atom:24460): Gtk-WARNING **: 17:14:02.694: Theme parsing error: gtk.css:132:46: The style property GtkScrolledWindow:scrollbars-within-bevel is deprecated and shouldn't be used anymore. It will be removed in a future version

[flamein]

I am still on 0.30.1; I stopped using the package due to this problem before ever seeing the project dropdown thing.

Hmmm, this means it might have been there a while longer and got worse over time.
I can trigger this reliably after opening just a few files...

As for the actual issue here: this is an utter mystery to me and I'm not sure where to even start debugging it. I don't believe this package hooks save or open actions at all. Maybe we're exhausting open file descriptors or something?
Are there any errors in the console when you try to save or open? Or, if not there, on the terminal if you launch atom with the --foreground --enable-electron-debugging flags?

I'll take a stab at it and report back

[flamein]

sure, after uninstalling the community package everything seems to be fine 🤦‍♂️

I'll get back when/if it returns. Maybe @larsgw can reproduce something

[larsgw]

I temporarily enabled it again on a repository with a GitLab remote to use the Git tab (perhaps those should be separated) and that works. I think there's really a problem with GitHub remotes.

[Xaenalt]

I am hit by this as well and disabling the github plugin does solve it, but the functionality was nice to have

[larsgw]

I just upgraded to 1.50.0 and the issue seems to be gone? I haven't had the window open for very long, so I can't say for sure yet.

[tallchellis]

I have had this issue in versions 1.50.0, 1.51.0 and 1.52.0. The problem occurs still in safe mode.