Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Blank slate info in the diff pane item #58

Closed
benogle opened this issue Mar 2, 2016 · 2 comments
Closed

Blank slate info in the diff pane item #58

benogle opened this issue Mar 2, 2016 · 2 comments
Assignees
@joshaber

Comments

@benogle
Copy link
Contributor

benogle commented Mar 2, 2016

When there is no diff, or there is a rename, we should have some indicator as to wtf is going on:

No diff:
screen shot 2016-03-01 at 4 33 44 pm

Rename:
screen shot 2016-02-26 at 3 37 33 pm

@simurai? We could use background messages:

screen shot 2016-03-01 at 4 29 38 pm
@benogle benogle mentioned this issue Mar 2, 2016
Closed
@simurai
Copy link
Contributor

simurai commented Mar 2, 2016

We could use background messages

Yes. For the rename, showing the old name is probably handy. Like old-file.txt > new-file.txt.

@benogle
Copy link
Contributor Author

benogle commented Mar 2, 2016

Yeah, we should show that in the header there, and in the file list.

@joshaber joshaber self-assigned this Mar 7, 2016
joshaber added a commit that referenced this issue Mar 7, 2016
@joshaber
Show a Diff Empty message if we don't have any hunks to display.
3ae9cb4 
Fixes #58
@joshaber joshaber mentioned this issue Mar 7, 2016
Merged
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joshaber joshaber

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@joshaber @benogle @simurai