Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move git and github tab items to a PaneItem #1547

Merged
merged 39 commits into from Jun 26, 2018

Conversation

Projects
2 participants
@smashwilson
Copy link
Member

smashwilson commented Jun 22, 2018

Let's eliminate some dead code and be a bit more consistent.

Fixes #1543.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Jun 22, 2018

Coverage Status

Coverage increased (+1.0%) to 72.308% when pulling 7df1b2f on aw/undock into 1e19579 on master.

smashwilson added some commits Jun 22, 2018

@smashwilson smashwilson force-pushed the aw/undock branch from 363047b to 2060693 Jun 22, 2018

smashwilson added some commits Jun 22, 2018

@smashwilson smashwilson referenced this pull request Jun 25, 2018

Closed

Startup and focus management issues, round N+1 #1552

0 of 4 tasks complete

smashwilson added some commits Jun 25, 2018

smashwilson added some commits Jun 26, 2018

@smashwilson

This comment has been minimized.

Copy link
Member Author

smashwilson commented Jun 26, 2018

Phew. Did not expect this one to take so long. In any case, it's working properly now. As a side bonus we have an integration test harness, too.

@smashwilson smashwilson merged commit 521d42e into master Jun 26, 2018

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

Feature Sprint: 18 June - 6 July 2018 automation moved this from In progress 🔧 to Merged ☑️ Jun 26, 2018

@smashwilson smashwilson deleted the aw/undock branch Jun 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.