Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR improvements #1583

Merged
merged 12 commits into from Jul 16, 2018

Conversation

Projects
None yet
2 participants
@simurai
Copy link
Member

simurai commented Jul 13, 2018

Description of the Change

Here a few (mostly visual) changes to the GitHub tab and PR detail pane.

Before After
image image

Benefits

  • Improved Markdown rendering.
  • PR pane adjusts when inside a dock.
  • Build status is at the top. No need to scroll down.
  • More visual consistency

Possible Drawbacks

None

Applicable Issues

Addresses some of #1582

@coveralls

This comment has been minimized.

Copy link

coveralls commented Jul 13, 2018

Coverage Status

Coverage increased (+0.3%) to 78.087% when pulling 0a9295a on sm/pr-improvements into e49cf73 on master.

@simurai simurai changed the title [WIP] PR improvements PR improvements Jul 16, 2018

@simurai simurai referenced this pull request Jul 16, 2018

Closed

More PR improvements #1582

4 of 5 tasks complete
@simurai

This comment has been minimized.

Copy link
Member Author

simurai commented Jul 16, 2018

Ok, I'll merge this and might follow up with the rest of #1582 in separate PRs.

@simurai simurai merged commit c9056b5 into master Jul 16, 2018

4 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.3%) to 78.087%
Details

@simurai simurai deleted the sm/pr-improvements branch Jul 16, 2018

@simurai simurai added the rfc-002 label Jul 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.