New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proxy items need to be more resilient to unexpected properties #1639

Merged
merged 3 commits into from Aug 13, 2018

Conversation

2 participants
@smashwilson
Member

smashwilson commented Aug 13, 2018

One of the Atom main process tests triggered a race condition in the Proxy we construct as an "item" to pass to the Atom API in PaneItem. A code path that iterated over the pane items in the workspace caused underscore.js to look for the .length property on every item, but that caused our Proxy to throw because its component RefHolder was still empty.

I'm armoring the Proxy items against empty holders to prevent this and turn it into a no-op.

@smashwilson smashwilson added this to In Progress 🔧 in Stability Sprint : 23 July - 3 August 2018 : v0.19.0 via automation Aug 13, 2018

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Aug 13, 2018

Coverage Status

Coverage decreased (-0.04%) to 80.215% when pulling 006671f on aw/atom-test-failure into ba551f6 on master.

coveralls commented Aug 13, 2018

Coverage Status

Coverage decreased (-0.04%) to 80.215% when pulling 006671f on aw/atom-test-failure into ba551f6 on master.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Aug 13, 2018

Coverage Status

Coverage decreased (-0.06%) to 80.199% when pulling 7c802fb on aw/atom-test-failure into ba551f6 on master.

coveralls commented Aug 13, 2018

Coverage Status

Coverage decreased (-0.06%) to 80.199% when pulling 7c802fb on aw/atom-test-failure into ba551f6 on master.

smashwilson added some commits Aug 13, 2018

@smashwilson smashwilson merged commit 3aa914c into master Aug 13, 2018

4 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.06%) to 80.199%
Details

Stability Sprint : 23 July - 3 August 2018 : v0.19.0 automation moved this from In Progress 🔧 to Merged ☑️ Aug 13, 2018

@smashwilson smashwilson deleted the aw/atom-test-failure branch Aug 13, 2018

smashwilson added a commit that referenced this pull request Aug 14, 2018

Merge pull request #1639 from atom/aw/atom-test-failure
Proxy items need to be more resilient to unexpected properties
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment