This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Proxy items need to be more resilient to unexpected properties #1639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smashwilson
added this to In Progress 🔧
in Stability Sprint : 23 July - 3 August 2018 : v0.19.0
via automation
Stability Sprint : 23 July - 3 August 2018 : v0.19.0
automation
moved this from In Progress 🔧
to Merged ☑️
Aug 13, 2018
smashwilson
added a commit
that referenced
this pull request
Aug 14, 2018
Proxy items need to be more resilient to unexpected properties
This was referenced Aug 14, 2018
Closed
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the Atom main process tests triggered a race condition in the Proxy we construct as an "item" to pass to the Atom API in
PaneItem. A code path that iterated over the pane items in the workspace caused underscore.js to look for the.lengthproperty on every item, but that caused our Proxy to throw because its componentRefHolderwas still empty.I'm armoring the Proxy items against empty holders to prevent this and turn it into a no-op.