New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily disable keytar-reliant tests on AppVeyor #1687

Merged
merged 1 commit into from Sep 10, 2018

Conversation

2 participants
@smashwilson
Member

smashwilson commented Sep 10, 2018

All Atom beta and dev-channel builds are currently experiencing issues building native modules correctly. See atom/atom#17997 for the tracking issue. Because it doesn't look like a trivial thing, I'm disabling the failing tests here on AppVeyor until we can work out the root cause.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Sep 10, 2018

Coverage Status

Coverage decreased (-0.04%) to 80.18% when pulling fe160e9 on aw/shhh-appveyor-shhh into 5cefdf0 on master.

coveralls commented Sep 10, 2018

Coverage Status

Coverage decreased (-0.04%) to 80.18% when pulling fe160e9 on aw/shhh-appveyor-shhh into 5cefdf0 on master.

@smashwilson smashwilson merged commit e482833 into master Sep 10, 2018

6 checks passed

ci/circleci: beta Your tests passed on CircleCI!
Details
ci/circleci: dev Your tests passed on CircleCI!
Details
ci/circleci: stable Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.04%) to 80.18%
Details

@smashwilson smashwilson deleted the aw/shhh-appveyor-shhh branch Sep 10, 2018

@smashwilson

This comment has been minimized.

Show comment
Hide comment
@smashwilson

smashwilson Sep 10, 2018

Member

@annthurium @kuychaco Okay, git pull origin master into your WIP branches and we won't be blocked by this anyway 😄

Member

smashwilson commented Sep 10, 2018

@annthurium @kuychaco Okay, git pull origin master into your WIP branches and we won't be blocked by this anyway 😄

@smashwilson smashwilson added this to In Progress 🔧 in Feature Sprint : 27 August - 14 September 2018 : v0.20.0 via automation Sep 10, 2018

@smashwilson smashwilson moved this from In Progress 🔧 to Merged ☑️ in Feature Sprint : 27 August - 14 September 2018 : v0.20.0 Sep 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment