-
Notifications
You must be signed in to change notification settings - Fork 391
Document the way we interact with git #1735
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a super informative & helpful doc! Thanks for writing this! ✨
A small comment: although I see how the sections under Repository
is closely related to the git interactions, it's probably important and big enough of a topic to warrant its own doc?
Do you mean the Repository states description? There is a bit more information about that (like a state transition diagram) in a README in the |
Oh yes I didn't realize we have this doc outside of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Thanks for writing this up @smashwilson 🙇♀️
Thanks for reading it over 🙇 |
Most interestingly, the way we intercept various kinds of credential prompts, and the differences between the different layers of the interface (what lives in
GitShellOutStrategy
vs.Repository
and its states).cc @sguthals @kuychaco @annthurium @vanessayuenn
🦄 r e n d e r e d 🦄