Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

package.json: pin @babel/core to less than 7.12.10 #2621

Merged
merged 1 commit into from
Feb 1, 2021

Conversation

DeeDeeG
Copy link
Contributor

@DeeDeeG DeeDeeG commented Feb 1, 2021

Please be sure to read the contributor's guide to the GitHub package before submitting any pull requests.

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.

Description of the Change

Restrict the @babel/core indirect dependency by pinning it to below 7.12.10. (Because 7.12.10 is incompatible with this package.)

Screenshot or Gif

N/A

Applicable Issues

Workaround for #2620

@DeeDeeG
Copy link
Contributor Author

DeeDeeG commented Feb 1, 2021

@smashwilson this PR (or a similar intervention) fixes two things:

  • Atom master branch currently can't load the github package in --dev mode. (Because Atom's main package-lock.json resolved the incompatible version of @babel/core as a dependency).
  • Atom currently can't load the github package installed via apm install atom/github. (Because apm install atom/github currently downloads the incompatible version of @babel/core as a dependency.)

By the way (steps to fully land this fix):

  • This can pretty easily be fixed at the Atom repo by manually editing Atom's package-lock.json to resolve @babel/core to an older version, say 7.12.9. So there's no need to necessarily cut a new release of the github package. And it can be fixed at the Atom repo without this PR being merged, actually.
  • Merging this PR would fix apm install atom/github though.

@codecov
Copy link

codecov bot commented Feb 1, 2021

Codecov Report

Merging #2621 (fb51a20) into master (6ab7dd6) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2621      +/-   ##
==========================================
- Coverage   93.46%   93.45%   -0.01%     
==========================================
  Files         237      237              
  Lines       13234    13234              
  Branches     1906     1906              
==========================================
- Hits        12369    12368       -1     
- Misses        865      866       +1     
Impacted Files Coverage Δ
lib/atom/gutter.js 90.47% <0.00%> (-2.39%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ab7dd6...fb51a20. Read the comment docs.

@smashwilson smashwilson merged commit 044931d into atom:master Feb 1, 2021
@smashwilson
Copy link
Contributor

  • Merging this PR would fix apm install atom/github though.

Definitely worth doing 👍🏻

Thanks!

@DeeDeeG
Copy link
Contributor Author

DeeDeeG commented Feb 2, 2021

Thanks for the merge!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants